status/network: Disconnect signal handler on destroy in NMConnectionItem

Otherwise this can trigger _sync() calls after the objects it is trying
to update have been destroyed.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4013

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1782>

diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 50423048c588a90f9843cec2c3c1a5faab9c0664..5487fde40fe403d875591f91472621d24f0162c5 100644 (file)
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -128,6 +128,11 @@ var NMConnectionItem = class {
     }
 
     destroy() {
+        if (this._activeConnectionChangedId) {
+            this._activeConnection.disconnect(this._activeConnectionChangedId);
+            this._activeConnectionChangedId = 0;
+        }
+
         this.labelItem.destroy();
         this.radioItem.destroy();
     }